Repository navigation
chore(cli): pin @relayflows/sdk 2.0.66 so 18.0.0 installs beside it - #2127
Conversation
The 18.0.0 publish (run 42576272570) failed the peer-compat release test with ERESOLVE: @relayflows/sdk 2.0.65's optional @agent-relay/sdk peer stops at <18. 2.0.66 (flows #709) accepts <19 and is otherwise 2.0.65. The pin moves in package.json, packages/cli/package.json, the product-surfaces range and the GitLab released-pins case. The lockfile changes only the @relayflows/sdk and nested @relayflows/surface entries and the two pin lines. A full regeneration also moved @agent-relay/sdk off its workspace link to a registry copy under packages/cli, so those entries are kept as on main, as for the Relay 17 pin (5a9f0b7). Validation: integrity hashes match the registry; npm ci accepts the lockfile and links @agent-relay/sdk to ./packages/sdk; relayflows-peer-compat.test.ts passes at 17.2.1 and with the CLI version set to 18.0.0; npm run typecheck passes. The full vitest run here hit ENOSPC (disk full), so CI is the full-suite check. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] The PR appears safe to merge; no actionable issues were found.
|
AgentRelayBot
left a comment
There was a problem hiding this comment.
One small but release-facing correction before approval: packages/cli/src/cli/commands/product-surfaces.ts still says the pinned Flows SDK has support for “Relay 15.1 through 17 peers.” This PR exists because 2.0.66 extends that peer contract through Relay 18, so the adjacent comment is now false. Please update it to “through 18” (or equivalent), rerun the focused checks, and request review on the exact successor head. The manifest/lock changes and registry integrities otherwise match the published 2.0.66 artifacts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AgentRelayBot
left a comment
There was a problem hiding this comment.
Approved exact successor head 7be1c37. The Relay-18 comment is corrected, the only changed artifacts remain the exact 2.0.66 pins/lock metadata/proof expectation, and both registry integrity values match npm. No unresolved threads. Merge after the refreshed required checks are terminal green.
Why
The 18.0.0 publish (run 42576272570) failed in Build & Version.
relayflows-peer-compat.test.tshit ERESOLVE because@relayflows/sdk@2.0.65's optional@agent-relay/sdkpeer stops at<18. Nothing was published.flows #709 widened that peer to
<19, and it's published as@relayflows/sdk2.0.66. #709 is the only flows change since 2.0.65.Change
@relayflows/sdk2.0.66 inpackage.json,packages/cli/package.jsonand theproduct-surfaces.tsrange.@relayflowsentries and the two pin lines change.npm install --package-lock-onlyalso moved@agent-relay/sdkoff its workspace link to a registry copy underpackages/cli, and markedpackages/sdkextraneous.main, so I kept those entries as they are onmain, the same as the Relay 17 pin (5a9f0b7).overridesentry stays unchanged; the publish workflow rewrites it during the version bump.Validation
@relayflows/sdkand@relayflows/surface2.0.66.npm ciaccepts the lockfile, andnpm lsshows@agent-relay/sdklinked to./packages/sdk.relayflows-peer-compat.test.tspasses at 17.2.1, and again with the CLI version set to 18.0.0, which is the case that failed the release.npm run typecheckpasses.After merge
Rerun the 18.0.0 publish (
package=all,version=major).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.